[llm] Fix start_pos not being updated in prefill_chunk() #11592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larryliu0820
requested review from
jackzhxng,
iseeyuan and
swolchok
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11592
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 2 Unrelated FailuresAs of commit 362f17d with merge base db96aba ( NEW FAILURES - The following jobs have failed:
FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
This PR needs a
|
|
@larryliu0820 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 12, 2025
Summary: This PR fixes `TextPrefiller` class `prefill_chunk` API. We should update `start_pos` at the end of the while loop. ### Enhancements to `TextPrefiller` functionality: * Renamed `prefillChunk` to `prefill_chunk` for consistency across method names in `TextPrefiller` class. Updates were made in both `text_prefiller.cpp` and `text_prefiller.h`. [[1]](diffhunk://#diff-a990c73be85dcbe7ef7e2ca02082fc0beb9951c1a8973587575a3e285f134cedL59-R74) [[2]](diffhunk://#diff-d8c18164204bbba3d0e0ccdf0c6e7f776f8865d66ec3b4129fcba641dcd7aed4L48-R48) * Adjusted the `start_pos` increment logic in the `prefill` method to ensure accurate position updates after processing each chunk. ### Comprehensive unit tests for `TextPrefiller`: * Added a new test file `test_text_prefiller.cpp` with detailed test cases for `TextPrefiller`, including edge cases, error handling, and scenarios for parallel and sequential prefill modes. Mock classes and spy implementations were introduced to facilitate testing. Differential Revision: D76483572 Pulled By: larryliu0820
facebook-github-bot
force-pushed
the
fix_prefill_chunk
branch
from
dc9cbba to
65086d1
Compare
|
This pull request was exported from Phabricator. Differential Revision: D76483572 |
Summary: This PR fixes `TextPrefiller` class `prefill_chunk` API. We should update `start_pos` at the end of the while loop. ### Enhancements to `TextPrefiller` functionality: * Renamed `prefillChunk` to `prefill_chunk` for consistency across method names in `TextPrefiller` class. Updates were made in both `text_prefiller.cpp` and `text_prefiller.h`. [[1]](diffhunk://#diff-a990c73be85dcbe7ef7e2ca02082fc0beb9951c1a8973587575a3e285f134cedL59-R74) [[2]](diffhunk://#diff-d8c18164204bbba3d0e0ccdf0c6e7f776f8865d66ec3b4129fcba641dcd7aed4L48-R48) * Adjusted the `start_pos` increment logic in the `prefill` method to ensure accurate position updates after processing each chunk. ### Comprehensive unit tests for `TextPrefiller`: * Added a new test file `test_text_prefiller.cpp` with detailed test cases for `TextPrefiller`, including edge cases, error handling, and scenarios for parallel and sequential prefill modes. Mock classes and spy implementations were introduced to facilitate testing. Differential Revision: D76483572 Pulled By: larryliu0820
facebook-github-bot
force-pushed
the
fix_prefill_chunk
branch
from
65086d1 to
362f17d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D76483572 |
mergennachin
approved these changes
Jun 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes
TextPrefillerclassprefill_chunkAPI. We should updatestart_posat the end of the while loop.Enhancements to
TextPrefillerfunctionality:prefillChunktoprefill_chunkfor consistency across method names inTextPrefillerclass. Updates were made in bothtext_prefiller.cppandtext_prefiller.h. [1] [2]start_posincrement logic in theprefillmethod to ensure accurate position updates after processing each chunk.Comprehensive unit tests for
TextPrefiller:test_text_prefiller.cppwith detailed test cases forTextPrefiller, including edge cases, error handling, and scenarios for parallel and sequential prefill modes. Mock classes and spy implementations were introduced to facilitate testing.