Skip to content

braodcast in op_le #11568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: gh/kimishpatel/190/base
Choose a base branch
from
Open

braodcast in op_le #11568

wants to merge 1 commit into from

Conversation

kimishpatel
Copy link
Contributor

@kimishpatel kimishpatel commented Jun 11, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

Differential Revision: D76456398

@kimishpatel
braodcast in op_le
5ef9025 
Differential Revision: [D76456398](https://our.internmc.facebook.com/intern/diff/D76456398/)

[ghstack-poisoned]
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jun 11, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11568

Note: Links to docs will display an error until the docs builds have been completed.

❌ 10 New Failures

As of commit 5ef9025 with merge base 2dda7a2 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

kimishpatel added a commit that referenced this pull request Jun 11, 2025
@kimishpatel
braodcast in op_le
c98045c 
Differential Revision: [D76456398](https://our.internmc.facebook.com/intern/diff/D76456398/)

ghstack-source-id: 289769544
Pull Request resolved: #11568
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 11, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D76456398

@github-actions GitHub Actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

manuelcandales
manuelcandales approved these changes Jun 12, 2025
View reviewed changes
Copy link
Contributor

@manuelcandales manuelcandales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to add a check at the top of this op that the dim orders must be the same, because I don't think any of this support different dim orders. But this was a preexisting issue, so, won't hold you on that.

manuelcandales
manuelcandales requested changes Jun 12, 2025
View reviewed changes
kernels/optimized/cpu/op_le.cpp
printf("selected_optimized_path: %d\n", static_cast<int>(selected_optimized_path));
if (selected_optimized_path == ElementwiseOptimizedPath::kTreatAs1d) {
// Resize for dynamic shape
auto error = resize_tensor(out, a.sizes());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is introducing the same bug you are fixing for op_mul in #11590

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manuelcandales manuelcandales manuelcandales approved these changes

@swolchok swolchok Awaiting requested review from swolchok swolchok is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kimishpatel @facebook-github-bot @manuelcandales