Skip to content

addresses the case when shape of upsample tensor contains ITensor #3841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

addresses the case when shape of upsample tensor contains ITensor #3841

wants to merge 3 commits into from
+92 −3

Conversation

apbose
Copy link
Collaborator

@apbose apbose commented Sep 27, 2025

Addresses #3783

@meta-cla meta-cla bot added the cla signed label Sep 27, 2025
@github-actions github-actions bot added component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: api [Python] Issues re: Python API component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths labels Sep 27, 2025
@github-actions github-actions bot requested a review from peri044 September 27, 2025 01:57
@github-actions github-actions bot added the component: tests Issues re: Tests label Oct 15, 2025
peri044
peri044 reviewed Oct 17, 2025
View reviewed changes
Copy link
Collaborator

@peri044 peri044 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think the functionality of to_trt_shape_tensor is probably available at couple of places (eg: concat iirc) manually. Do you think we could unify all this ?

@apbose
Copy link
Collaborator Author

apbose commented Oct 17, 2025

yeah thats true. cat does it for inputs while the above is for shape tensor. Yeah I guess we could unify this. Should
I merge this for now since it addresses user error? Or do you think I should merge after unifying?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@peri044 peri044 peri044 left review comments

Assignees

No one assigned

Labels

cla signed component: api [Python] Issues re: Python API component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: tests Issues re: Tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@apbose @peri044