-
Notifications
You must be signed in to change notification settings - Fork 665
Add Paged Attention to FMHA Cutlass Blackwell Forward kernel for fixed length #4999
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sarithad-meta
wants to merge
1
commit into
pytorch:main
Choose a base branch
from
sarithad-meta:export-D84023396
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
@sarithad-meta has exported this pull request. If you are a Meta employee, you can view the originating Diff in D84023396. |
7ddeab4
to
d007740
Compare
sarithad-meta
added a commit
to sarithad-meta/FBGEMM-1
that referenced
this pull request
Oct 13, 2025
…d length (pytorch#4999) Summary: X-link: facebookresearch/FBGEMM#2013 Added paged attention support to FMHA FWD blackwell kernel. 1. Added support for fixed length case. 2. Added support for 2 cases: a) page_block_size = N tile size b) page_block_size > N 3. Added unit test, test_paged_forward. Next steps: 1. Test the performance of fixed length case. 2. Add support for variable length case to FWD kernel. 3. Add support for small page sizes to FWD kernel. 4. Add paged attention support for decode. Differential Revision: D84023396
d007740
to
3dde689
Compare
sarithad-meta
added a commit
to sarithad-meta/FBGEMM-1
that referenced
this pull request
Oct 16, 2025
…d length (pytorch#4999) Summary: X-link: facebookresearch/FBGEMM#2013 Added paged attention support to FMHA FWD blackwell kernel. 1. Added support for fixed length case. 2. Added support for 2 cases: a) page_block_size = N tile size b) page_block_size > N 3. Added unit test, test_paged_forward. Next steps: 1. Test the performance of fixed length case. 2. Add support for variable length case to FWD kernel. 3. Add support for small page sizes to FWD kernel. 4. Add paged attention support for decode. Reviewed By: Aya-ZIbra, sijiac Differential Revision: D84023396
3dde689
to
0f54e39
Compare
sarithad-meta
added a commit
to sarithad-meta/FBGEMM-1
that referenced
this pull request
Oct 17, 2025
…d length (pytorch#4999) Summary: Pull Request resolved: pytorch#4999 X-link: https://github.com/facebookresearch/FBGEMM/pull/2013 Added paged attention support to FMHA FWD blackwell kernel. 1. Added support for fixed length case. 2. Added support for 2 cases: a) page_block_size = N tile size b) page_block_size > N 3. Added unit test, test_paged_forward. Next steps: 1. Test the performance of fixed length case. 2. Add support for variable length case to FWD kernel. 3. Add support for small page sizes to FWD kernel. 4. Add paged attention support for decode. Reviewed By: Aya-ZIbra, sijiac Differential Revision: D84023396
…d length (pytorch#4999) Summary: Pull Request resolved: pytorch#4999 X-link: https://github.com/facebookresearch/FBGEMM/pull/2013 Added paged attention support to FMHA FWD blackwell kernel. 1. Added support for fixed length case. 2. Added support for 2 cases: a) page_block_size = N tile size b) page_block_size > N 3. Added unit test, test_paged_forward. Next steps: 1. Test the performance of fixed length case. 2. Add support for variable length case to FWD kernel. 3. Add support for small page sizes to FWD kernel. 4. Add paged attention support for decode. Reviewed By: Aya-ZIbra, sijiac Differential Revision: D84023396
0f54e39
to
298beb6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: https://github.com/facebookresearch/FBGEMM/pull/2013
Added paged attention support to FMHA FWD blackwell kernel.
Next steps:
Differential Revision: D84023396