Skip to content

chore(deps): replace curlylint with djlint #18175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

chore(deps): replace curlylint with djlint #18175

wants to merge 6 commits into from

Conversation

miketheman
Copy link
Member

@miketheman miketheman commented May 22, 2025 •
edited
Loading

Suggestion: review this PR with "ignore whitespace".

Some rules were disabled to make this achievable in a short term, and can be resolved after this is completed.

Locally, djlint is faster than curlylint - ~3 seconds vs ~14 seconds for the same amount of files.

@miketheman miketheman added HTML requires change to HTML files developer experience Anything that improves the experience for Warehouse devs dependencies Pull requests that update a dependency file labels May 22, 2025
@miketheman
Copy link
Member Author

Should probably come after #18148 is merged.

@miketheman miketheman force-pushed the miketheman/idea-djlint branch from 83e5fc4 to 85b0e20 Compare June 2, 2025 18:11
@miketheman miketheman force-pushed the miketheman/idea-djlint branch from 85b0e20 to 80b39ab Compare June 2, 2025 18:11
@miketheman miketheman marked this pull request as ready for review June 2, 2025 18:13
@miketheman miketheman requested a review from a team as a code owner June 2, 2025 18:13
ewdurbin
ewdurbin approved these changes Jun 11, 2025
View reviewed changes
Copy link
Member

@ewdurbin ewdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an obvious commit in this tree that is predominately ignorable? Candidate for splitting up to yeet into https://github.com/pypi/warehouse/blob/main/.git-blame-ignore-revs

requirements/lint.txt
# via
# djlint
# sphinx-lint
six==1.17.0 \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in this, the year 2025????

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewdurbin ewdurbin ewdurbin approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file developer experience Anything that improves the experience for Warehouse devs HTML requires change to HTML files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@miketheman @ewdurbin