Skip to content

Remove all platform-level dependencies #18150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 11, 2025

Conversation

di
Copy link
Member

@di di commented May 18, 2025

As a result of #18058, we don't need need these anymore.

The one exception is that we still need postgresql-client in our development containers to run various database-related commands.

Edit: we also need build-essential to provide make to our docs and dev builds.

@di di requested a review from a team as a code owner May 18, 2025 19:01
@di
Copy link
Member Author

di commented May 18, 2025

Looks like this shaves about 30s off the Docker image build. 🚀

@ewdurbin ewdurbin enabled auto-merge (squash) June 11, 2025 19:51
@ewdurbin ewdurbin merged commit 3682d90 into pypi:main Jun 11, 2025
20 checks passed
@miketheman
Copy link
Member

miketheman commented Jun 11, 2025

This broke make totp by removing oathtool:

$ make totp
bin/devtotp: line 3: oathtool: command not found

make: *** [totp] Error 127

@miketheman
Copy link
Member

Also looks like it broke make blog:

$ make blog
...
  File "/opt/warehouse/lib/python3.13/site-packages/git/__init__.py", line 298, in <module>
    raise ImportError("Failed to initialize: {0}".format(_exc)) from _exc
ImportError: Failed to initialize: Bad git executable.
The git executable must be specified in one of the following ways:
    - be included in your $PATH
    - be set via $GIT_PYTHON_GIT_EXECUTABLE
    - explicitly set via git.refresh(<full-path-to-git-executable>)

All git commands will error until this is rectified.

This initial message can be silenced or aggravated in the future by setting the
$GIT_PYTHON_REFRESH environment variable. Use one of the following values:
    - quiet|q|silence|s|silent|none|n|0: for no message or exception
    - warn|w|warning|log|l|1: for a warning message (logging level CRITICAL, displayed by default)
    - error|e|exception|raise|r|2: for a raised exception

Example:
    export GIT_PYTHON_REFRESH=quiet


make: *** [blog] Error 1

@ewdurbin
Copy link
Member

#18252

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants