Skip to content

Mark more tests as requiring network #13378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 6, 2025
Merged

Mark more tests as requiring network #13378

merged 2 commits into from
May 6, 2025

Conversation

mgorny
Copy link
Contributor

@mgorny mgorny commented May 5, 2025

Apply the network mark to more tests that attempt to install packages from PyPI and other online sources, and therefore fail without Internet access.

To reproduce:

nox -e test-3.13
sudo unshare -n sh -c "ifconfig lo up && sudo -u $USER sh -c \". .nox/test-3-13/bin/activate && pytest -n auto -m 'not network'\""

mgorny added 2 commits May 5, 2025 07:42
Apply the `network` mark to more tests that attempt to install packages
from PyPI and other online sources, and therefore fail without Internet
access.

To reproduce:

```
nox -e test-3.13
sudo unshare -n sh -c "ifconfig lo up && sudo -u $USER sh -c \". .nox/test-3-13/bin/activate && pytest -n auto -m 'not network'\""
```
@mgorny mgorny marked this pull request as ready for review May 5, 2025 05:47
@ichard26 ichard26 added the skip news Does not need a NEWS file entry (eg: trivial changes) label May 5, 2025
Copy link
Member

@ichard26 ichard26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At some point, I'd like to revive #13142 to catch these missing markers, but alas, that day is not today.

Thanks!

@ichard26 ichard26 merged commit e6db004 into pypa:main May 6, 2025
29 checks passed
@mgorny
Copy link
Contributor Author

mgorny commented May 7, 2025

Thanks!

@mgorny mgorny deleted the no-network branch May 7, 2025 00:54
@hroncok
Copy link
Contributor

hroncok commented May 7, 2025

Thanks.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bot:chronographer:provided skip news Does not need a NEWS file entry (eg: trivial changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants