Update invalid-envvar-default to flag os.environ.get

[Aearsears]

Type of Changes

	Type
✓	🐛 Bug fix
	✨ New feature
	🔨 Refactoring
	📜 Docs

Description

This PR updates the StdLibchecker to check for invalid-envvar-default and invalid-envvar-value when calling os.environ.get. os.environ is a mapping object and it calls concretely builtins.dict 's get method

Relates to PR #10094

Closes #10092

[Aearsears]

should I create a news fragment for this change?

[Pierre-Sassoulas]

Yes, indeed :) thank you for the MR, I skimmed and i've seen nothing shocking, will review in depth later. Great first contribution !

[Pierre-Sassoulas]

Seeing the messages in the primer, we should probably not raise for int(os.get.environ("SOMETHING", 1) or float(os.get.environ("SOMETHING", 1.0), but let's remember that it's the work of a type checker to warn about this not pylint, and type checkers exists. (Don't want to discourage you, and you did great work, but they are more value in fixing other checks and other bugs in the backlog)

[Aearsears]

thanks for the review Pierre-Sassoulas, i'll see if I can find a quick solution to what you mentioned, otherwise i'll close this pr and contribute to other issues as you suggested

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.85%. Comparing base (a52dd58) to head (3b0fac2).
⚠️ Report is 29 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #10507   +/-   ##
=======================================
  Coverage   95.85%   95.85%           
=======================================
  Files         177      177           
  Lines       19284    19293    +9     
=======================================
+ Hits        18484    18493    +9     
  Misses        800      800           

Files with missing lines	Coverage Δ
pylint/checkers/stdlib.py	96.38% <100.00%> (+0.11%)	⬆️

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[github-actions]

🤖 Effect of this PR on checked open source code: 🤖

Effect on sentry:
The following messages are now emitted:

1. invalid-envvar-default:
   os.environ.get default type is builtins.bool. Expected str or None.
   https://github.com/getsentry/sentry/blob/cd3fcd3738d0f530e00c2eed8318cae4af3b6745/src/sentry/apidocs/utils.py#L74
2. invalid-envvar-default:
   os.environ.get default type is builtins.bool. Expected str or None.
   https://github.com/getsentry/sentry/blob/cd3fcd3738d0f530e00c2eed8318cae4af3b6745/src/sentry/conf/server.py#L736
3. invalid-envvar-default:
   os.environ.get default type is builtins.bool. Expected str or None.
   https://github.com/getsentry/sentry/blob/cd3fcd3738d0f530e00c2eed8318cae4af3b6745/src/sentry/conf/server.py#L1966
4. invalid-envvar-default:
   os.environ.get default type is builtins.bool. Expected str or None.
   https://github.com/getsentry/sentry/blob/cd3fcd3738d0f530e00c2eed8318cae4af3b6745/src/sentry/conf/server.py#L2978
5. invalid-envvar-default:
   os.environ.get default type is builtins.bool. Expected str or None.
   https://github.com/getsentry/sentry/blob/cd3fcd3738d0f530e00c2eed8318cae4af3b6745/src/sentry/conf/server.py#L3018
6. invalid-envvar-default:
   os.environ.get default type is builtins.bool. Expected str or None.
   https://github.com/getsentry/sentry/blob/cd3fcd3738d0f530e00c2eed8318cae4af3b6745/src/sentry/conf/server.py#L3135
7. invalid-envvar-default:
   os.environ.get default type is builtins.bool. Expected str or None.
   https://github.com/getsentry/sentry/blob/cd3fcd3738d0f530e00c2eed8318cae4af3b6745/src/sentry/conf/server.py#L3879
8. invalid-envvar-default:
   os.environ.get default type is builtins.bool. Expected str or None.
   https://github.com/getsentry/sentry/blob/cd3fcd3738d0f530e00c2eed8318cae4af3b6745/src/sentry/runner/settings.py#L129

This comment was generated for commit 3b0fac2