Fix RuntimeError in maybe_num_nodes_dict with empty edge indices from #10386 #10483
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug where
maybe_num_nodes_dict
would crash with aRuntimeError
when processing heterogeneous graphs containing empty edge indices.Problem
The function calls
.max()
on edge index tensors without checking if they are empty. PyTorch requires specifying a reduction dimension when calling.max()
on empty tensors, causing the following error:Reproducer
Solution
Added checks for empty tensors (
numel() > 0
) before calling.max()
, returning 0 for empty edge indices, which is the correct behavior for graphs with no edges of a particular type.Impact
This bug affects users working with heterogeneous graphs where some edge types have no edges - a common scenario in real-world applications:
Testing
Added comprehensive test coverage in
test/utils/test_num_nodes.py
:num_nodes_dict
All tests pass successfully.
Checklist