Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR fix?
This PR fixes the cluster loss (
L_c
) calculation inDMoNPooling
. Previously, the implementation incorrectly normalized the loss using a wrongly shaped tensor derived from the node mask (mask.sum(dim=1)
wheremask
had shapeB × N × 1
). This led to unintended broadcasting and incorrect values for the cluster loss.Changes made
node_mask_2d
) to compute valid node counts per graph.n_per_graph
with shapeB
, ensuring correct normalization.Impact
L_c
.Closes: #10148