Scattering-freefield #8
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Marco Berzborn <[email protected]>
sikersten
requested changes
Oct 12, 2022
imkar/scattering/coefficient.py
Outdated
Comment on lines
69
to
72
| # calculate random-incidence scattering coefficient | ||
| if incident_directions is not None: | ||
| s_rand = random_incidence(s, incident_directions) | ||
| return s, s_rand |
There was a problem hiding this comment.
Suggested change
| # calculate random-incidence scattering coefficient | |
| if incident_directions is not None: | |
| s_rand = random_incidence(s, incident_directions) | |
| return s, s_rand |
| from imkar.testing import stub_utils | ||
|
|
||
|
|
||
| @pytest.fixture |
There was a problem hiding this comment.
maybe I'm missing something here: What's the reason for not using pyfar.samplings?
There was a problem hiding this comment.
The shape of the data is quite different, pyfar.samplings just returns a flatten Coordinates object. we need a cshape of (#angle_1, #angle_2)
| @@ -0,0 +1,34 @@ | |||
| """ | |||
There was a problem hiding this comment.
If you really want to provide stub utils, please add test for them
# Conflicts: # tests/test_integrate.py
# Conflicts: # tests/test_integrate.py
|
#9 will remove tests for Python 3.7 |
|
doc fails, fixes in #10 |
|
is obsolte and replaces by #12 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request: