-
Notifications
You must be signed in to change notification settings - Fork 2
Feature: correlation method after mommertz #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ahms5
wants to merge
5
commits into
develop
Choose a base branch
from
scattering/correlation_method
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahms5
commented
May 26, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a new correlation method to calculate the scattering coefficient from free-field measurements based on the Mommertz method. Key changes include:
- Implementation of the correlation_method in imkar/scattering/freefield.py.
- Addition of comprehensive tests for the new method in tests/test_scattering_freefield.py.
- Updates to module exports and documentation to include the new scattering functionality.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
tests/test_scattering_freefield.py | New tests validating the correlation_method behavior and type checks. |
imkar/scattering/freefield.py | Implementation of the new correlation_method following Mommertz. |
imkar/scattering/init.py | Updated module export for scattering functions. |
imkar/init.py | Updated package initialization to include the scattering module. |
docs/modules/imkar.scattering.freefield.rst | Documentation update for the new free-field scattering method. |
docs/api_reference.rst | Reference documentation updated to feature the new module. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) are closed by this pull request?
Closes #12
Changes proposed in this pull request:
requires #32