Skip to content

2D FVM #5002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 21 commits into
base: develop
Choose a base branch
from
Draft

2D FVM #5002

wants to merge 21 commits into from

Conversation

aabills
Copy link
Contributor

@aabills aabills commented Apr 30, 2025

Description

This pull request contains a 2D finite volume spatial method.
It will be a WIP for a bit, making a draft for sharing purposes.

Fixes # (issue)

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #)

Important checks:

Please confirm the following before marking the PR as ready for review:

  • No style issues: nox -s pre-commit
  • All tests pass: nox -s tests
  • The documentation builds: nox -s doctests
  • Code is commented for hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

Copy link

codecov bot commented Apr 30, 2025

Codecov Report

Attention: Patch coverage is 26.71233% with 749 lines in your changes missing coverage. Please review.

Project coverage is 95.59%. Comparing base (34186fe) to head (109a220).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
src/pybamm/spatial_methods/finite_volume_2d.py 18.34% 650 Missing ⚠️
src/pybamm/meshes/meshes.py 37.25% 32 Missing ⚠️
src/pybamm/discretisations/discretisation.py 45.71% 19 Missing ⚠️
src/pybamm/meshes/two_dimensional_submeshes.py 76.38% 17 Missing ⚠️
src/pybamm/expression_tree/vector_field.py 31.81% 15 Missing ⚠️
src/pybamm/solvers/processed_variable.py 40.00% 6 Missing ⚠️
src/pybamm/expression_tree/unary_operators.py 62.50% 3 Missing ⚠️
src/pybamm/parameters/parameter_values.py 40.00% 3 Missing ⚠️
src/pybamm/solvers/solution.py 25.00% 3 Missing ⚠️
src/pybamm/meshes/one_dimensional_submeshes.py 92.85% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5002      +/-   ##
===========================================
- Coverage    98.57%   95.59%   -2.98%     
===========================================
  Files          304      307       +3     
  Lines        23645    24654    +1009     
===========================================
+ Hits         23309    23569     +260     
- Misses         336     1085     +749     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant