Added type hints to constant_concentration.py #4956
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a trial PR to test adding type hints. I’ve verified that it doesn’t change any mypy behavior at this stage, but it’s intended to gather feedback on approach and clarity. Happy to change this to a draft if needed.
Fixes #4954
Type of change
This PR focuses on:
Adding type hints to helper functions that return basic types.
Adding hints to class methods with simple input/output signatures.
Ensuring compatibility with existing code and mypy.
Motivation
I’d like to familiarize myself with PyBaMM’s contribution process and get early feedback on:
Type hinting conventions
Review expectations
Important checks:
Please confirm the following before marking the PR as ready for review:
nox -s pre-commit
nox -s tests
nox -s doctests