Skip to content

fix: order of menu registration to come after keybindings registration #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

tlambert03
Copy link
Member

fixes #244

Copy link

codecov bot commented Jun 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.79%. Comparing base (c69647e) to head (d6f939b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #249   +/-   ##
=======================================
  Coverage   99.79%   99.79%           
=======================================
  Files          31       31           
  Lines        1905     1905           
=======================================
  Hits         1901     1901           
  Misses          4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tlambert03 tlambert03 closed this Jun 18, 2025
@tlambert03 tlambert03 reopened this Jun 18, 2025
@tlambert03 tlambert03 merged commit a95379f into pyapp-kit:main Jun 18, 2025
76 of 91 checks passed
@tlambert03 tlambert03 deleted the fix-late-registration-keybinding branch June 18, 2025 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Adding actions after MainWindow instantiated doesn't set keybindings (Qt)
1 participant