-
Notifications
You must be signed in to change notification settings - Fork 1.5k
MAINT: Increase readability of _merge_page #3291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Mainly moving declarations nearer their use.
Mainly moving declarations nearer their use.
This PR is wrong, I should not have moved the annotations. Will either close or change... |
I am going to mark this PR as draft. Feel free to either close or mark it ready for review if you decided on an approach. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3291 +/- ##
=======================================
Coverage 96.69% 96.69%
=======================================
Files 53 53
Lines 9024 9024
Branches 1674 1674
=======================================
Hits 8726 8726
Misses 176 176
Partials 122 122 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@stefan6419846 code coverage has decreased but seems as if it should be the same? Moving the annotations is okay also. |
The case where https://github.com/py-pdf/pypdf/pull/3291/files#diff-153e5cee71ddf471246ff5c0e198345f005942a540a8f39297736f0b620d631dR1225 does not hold true is not covered by the tests (although it has never been as far as I can see). Are we able to test this as well? |
No description provided.