Skip to content

MAINT: Increase readability of _merge_page #3291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

j-t-1
Copy link
Contributor

@j-t-1 j-t-1 commented May 21, 2025

No description provided.

j-t-1 added 2 commits May 21, 2025 14:54
Mainly moving declarations nearer their use.
Mainly moving declarations nearer their use.
@j-t-1
Copy link
Contributor Author

j-t-1 commented May 21, 2025

This PR is wrong, I should not have moved the annotations. Will either close or change...

@stefan6419846
Copy link
Collaborator

I am going to mark this PR as draft. Feel free to either close or mark it ready for review if you decided on an approach.

@stefan6419846 stefan6419846 marked this pull request as draft May 21, 2025 15:43
Copy link

codecov bot commented May 21, 2025

Codecov Report

Attention: Patch coverage is 95.83333% with 1 line in your changes missing coverage. Please review.

Project coverage is 96.69%. Comparing base (15c42ff) to head (17afa32).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
pypdf/_page.py 95.83% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3291   +/-   ##
=======================================
  Coverage   96.69%   96.69%           
=======================================
  Files          53       53           
  Lines        9024     9024           
  Branches     1674     1674           
=======================================
  Hits         8726     8726           
  Misses        176      176           
  Partials      122      122           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@j-t-1 j-t-1 marked this pull request as ready for review May 21, 2025 21:00
@j-t-1
Copy link
Contributor Author

j-t-1 commented May 21, 2025

@stefan6419846 code coverage has decreased but seems as if it should be the same? Moving the annotations is okay also.

@stefan6419846
Copy link
Collaborator

The case where https://github.com/py-pdf/pypdf/pull/3291/files#diff-153e5cee71ddf471246ff5c0e198345f005942a540a8f39297736f0b620d631dR1225 does not hold true is not covered by the tests (although it has never been as far as I can see). Are we able to test this as well?

@stefan6419846 stefan6419846 added the needs-test A test should be added before this PR is merged. label Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-test A test should be added before this PR is merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants