Skip to content

add enhanced logging in check fee #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: testnet3
Choose a base branch
from
Open

add enhanced logging in check fee #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions synthesizer/src/vm/verify.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,11 +236,20 @@ impl<N: Network, C: ConsensusStorage<N>> VM<N, C> {
// Compute the execution cost.
let (cost, _) = execution_cost(&self.process().read(), execution)?;
// Ensure the fee is sufficient to cover the cost.
if *fee.base_amount()? < cost {
let base_amount = *fee.base_amount()?; // Get the amount once to avoid multiple ? operations
if base_amount < cost {
trace!(
"Transaction '{}' fee check failed - base amount: {}, required cost: {}",
id,
base_amount,
cost
);
bail!(
"Transaction '{id}' has an insufficient base fee (execution) - requires {cost} microcredits"
"Transaction '{id}' has an insufficient base fee (execution) - requires {cost} microcredits",
id = id,
cost = cost
)
}
}
} else {
// Ensure the base fee amount is zero.
ensure!(*fee.base_amount()? == 0, "Transaction '{id}' has a non-zero base fee (execution)");
Expand Down