Skip to content

Update Season 1 close out #2034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 25, 2025
Merged

Update Season 1 close out #2034

merged 3 commits into from
Mar 25, 2025

Conversation

corlard3y
Copy link
Collaborator

Pull Request Template

#2033

Description

  • Problem/Feature:
    • On app.push.org/points remove all tabs and have only the colorful banner visible with total points/multiplier etc. Make sure correct number of points are showing. Title changes to Push Points S2 is Live! Sub text changes to Season 1 has ended and your points have been snapshot. Participate in Season 2 at portal.push.org/rewards Change Button to Go to Season 2 and that button takes user to portal.push.org/rewards

Type of Change

  • Bug fix
  • New feature
  • Code refactor
  • Documentation update
  • Other (please describe):

Checklist

  • Quick PR: Is this a quick PR? Can be approved before finishing a coffee.
    • Quick PR label added
  • Not Merge Ready: Is this PR dependent on some other PR/tasks and not ready to be merged right now.
    • DO NOT Merge PR label added

Frontend Guidelines

Build & Testing

  • No errors in the build terminal
  • Engineer has tested the changes on their local environment
  • Engineer has tested the changes on deploy preview

Screenshots/Video with Explanation

  • Before: Explain the previous behavior

  • After: What's changed now

Additional Context

Review & Approvals

  • Self-review completed
  • Code review by at least one other engineer
  • Documentation updates if applicable

Notes

@corlard3y corlard3y linked an issue Mar 24, 2025 that may be closed by this pull request
Copy link

In the file public/404.html:

  1. Looks like there is a typo in the comment here: "// Note: this 404.html file must be at least 512 bytes for it to work".
  2. In the JavaScript code, there is a missing closing curly brace '}' for the block starting with "if (!chainId) {" in the function walletToFullCAIP10.
  3. The function walletToFullCAIP10 is missing a closing curly brace '}' at the end.
  4. There is a missing closing curly brace '}' for the try block in the decryptMessages function.
  5. The decryptAndVerifySignature function is missing a closing curly brace '}' at the end.
  6. In the formatFileSize function, there is a typo in "Math.floor(Math.log(size) / Math.log(1024)" should be "Math.floor(Math.log(size) / Math.log(1024))".

In the file src/helpers/w2w/index.ts:

  1. There is a missing closing curly brace '}' at the end of the file.

In the file src/modules/rewards/Rewards.tsx:

  1. The closing tag for the Text component is missing in the JSX.

In the file src/modules/rewards/components/DashboardSectionHeader.tsx:

  1. The Button component is missing the children prop, e.g., it should be Go To Season 2.

Other files are not provided for review.

Overall, a few typos and missing curly braces have been identified. Once these issues are fixed, the code should be good to go.

All looks good.

Copy link

github-actions bot commented Mar 24, 2025

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2025-03-25 07:44 UTC

Copy link

In the code provided, I have checked for mistakes, typos, and logic errors. Here are the findings for each file:

  1. File: public/404.html

    • No noticeable mistakes, typos, or logic errors found.
    • All looks good.
  2. File: src/helpers/w2w/index.ts

    • In the decryptMessages function, there is a missing closing bracket after the line if (checkIfGroup(currentChat)) {.
    • In the same function, there is a missing closing bracket after the line if (latestUserInfo) {.
    • After the decryptAndVerifySignature function inside try-catch block, there is a missing closing bracket } and a missing semicolon ; at the end.
    • The formatFileSize function is missing a closing bracket } at the end.
    • After the export default { ... statement, there is missing a closing curly brace }.
    • Potential typo: signatureValidationPubliKey should be signatureValidationPublicKey.
  3. File: src/modules/rewards/Rewards.tsx

    • No noticeable mistakes, typos, or logic errors found.
    • All looks good.
  4. File: src/modules/rewards/components/DashboardSection.tsx

    • In the Box component, there is a missing closing curly brace } at the end of flexDirection property.
    • In the Text component after variant="h4-semibold", there is no content specified.
    • In the Box component after display={{ ml: 'block', initial: 'none' }}, there is no closing brace }.
    • In the Box component after <Text variant="h4-bold" color="text-primary">Dashboard</Text>, the closing brace is missing.
    • In the DashboardSectionPoints component declaration, the closing angle bracket > is missing at the end of the component structure.
  5. File: src/modules/rewards/components/DashboardSectionHeader.tsx

    • No noticeable mistakes, typos, or logic errors found.
    • All looks good.
  6. File: src/modules/rewards/components/DashboardSectionPoints.tsx

    • In the Text component after {rank > 0 && "Rank #${rank}"}, the interpolation syntax should be ${rank} to correctly display the value of rank.
    • The structure of conditional rendering and component nesting might need review for accuracy.
  7. File: src/modules/rewards/components/RewardsTabsContainer.tsx

    • The file is empty and contains no code to review.
  8. File: src/structure/MasterInterfacePage.tsx

    • The file is not provided in the snippets shared.

Please correct the identified issues in the respective files. If you have any further questions or need more assistance, feel free to ask.

@riyanshu-patro riyanshu-patro self-requested a review March 24, 2025 14:38
@corlard3y corlard3y requested a review from abhishek-01k March 24, 2025 14:40
@riyanshu-patro riyanshu-patro merged commit 36dd66b into main Mar 25, 2025
2 checks passed
@riyanshu-patro riyanshu-patro deleted the 2033-update-rewards-s1 branch March 25, 2025 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Rewards S1
3 participants