Skip to content

Fix lint errors #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 10, 2024
Merged

Fix lint errors #154

merged 1 commit into from
Jan 10, 2024

Conversation

@kajinamit
Copy link
Collaborator

@kajinamit kajinamit commented Jan 10, 2024 •
edited
Loading

Fixes the lint errors found in #153 .

@kajinamit kajinamit requested a review from a team as a code owner January 10, 2024 06:04
@kajinamit kajinamit mentioned this pull request Jan 10, 2024
Open
ekohl
ekohl approved these changes Jan 10, 2024
View reviewed changes
Copy link
Contributor

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would call these lint errors, not syntax errors. Otherwise 👍 and I'll fix up the commit message on squash.

@ekohl
Copy link
Contributor

ekohl commented Jan 10, 2024

Oh wait, I don't have merge permissions here.

@kajinamit kajinamit changed the title Fix syntax test errors Fix lint errors Jan 10, 2024
@binford2k binford2k merged commit 32c7adb into puppetlabs:main Jan 10, 2024
@kajinamit kajinamit deleted the syntax-fix branch February 4, 2024 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@ekohl ekohl ekohl approved these changes

@binford2k binford2k binford2k approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kajinamit @ekohl @binford2k