Skip to content

Conversation

daniel-sheward
Copy link

Fixes #1049.

This restores functionality that appears to exist in previous versions.

I've modified the arguments to take assignIpv6AddressOnCreation which decides if a subnet should get an IPv6 CIDR.

Copy link

github-actions bot commented Jul 3, 2025

PR is now waiting for a maintainer to run the acceptance tests.
Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@blampe
Copy link
Contributor

blampe commented Jul 7, 2025

/run-acceptance-tests

Copy link

github-actions bot commented Jul 7, 2025

Please view the PR build: https://github.com/pulumi/pulumi-awsx/actions/runs/16123242006

@blampe
Copy link
Contributor

blampe commented Jul 7, 2025

/run-acceptance-tests

Copy link

github-actions bot commented Jul 7, 2025

Please view the PR build: https://github.com/pulumi/pulumi-awsx/actions/runs/16127691569

@blampe
Copy link
Contributor

blampe commented Jul 11, 2025

/run-acceptance-tests

Copy link

Please view the PR build: https://github.com/pulumi/pulumi-awsx/actions/runs/16224955819

Copy link

PR is now waiting for a maintainer to run the acceptance tests.
Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@blampe
Copy link
Contributor

blampe commented Jul 11, 2025

/run-acceptance-tests

Copy link

Please view the PR build: https://github.com/pulumi/pulumi-awsx/actions/runs/16225882267

Copy link

PR is now waiting for a maintainer to run the acceptance tests.
Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@blampe
Copy link
Contributor

blampe commented Jul 11, 2025

/run-acceptance-tests

Copy link

Please view the PR build: https://github.com/pulumi/pulumi-awsx/actions/runs/16231219097

@blampe
Copy link
Contributor

blampe commented Jul 11, 2025

TSError: ⨯ Unable to compile TypeScript:

index.ts(7,7): error TS2322: Type 'string' is not assignable to type '"Private" | "Public" | "Isolated" | "Unused"'.
index.ts(11,7): error TS2322: Type 'string' is not assignable to type '"Private" | "Public" | "Isolated" | "Unused"'.

I'm not able to repro this failure locally. Very odd, especially because there are several other tests with similar subnet specs (e.g. TestLbSimple).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

subnets created by awsx.ec2.vpc do not get ipv6 netblocks assigned

2 participants