eval: tolerate syntax errors #596
Conversation
We must tolerate syntax errors when loading an environment. Returning a nil `EnvironmentDecl` prevents us from being able to analyze the portions of the environment that were successfully parsed. This interferes with analysis of environments that are only partially erroneous. One important scenario this covers is autocompletion in the face of syntax errors, which is common while editing an environment.
pgavlin
force-pushed
the
pgavlin/load-syntax
branch
from
2be78f3 to
ae1b32c
Compare
| if tdiags.HasErrors() { | ||
| return nil, diags, nil | ||
| } | ||
|
|
There was a problem hiding this comment.
this is the core of the fix. the other edits in this PR are changes to accommodate nil object keys. I don't think we have other places that need nil checks, as everything else goes through declare, and declare will produce missingExpr values for nil AST nodes.
|
Validated on a dev stack that this does fix autocomplete in the ESC console. |
There was a problem hiding this comment.
Looks simple enough and the expected.json results help. But as an ESC rookie I would like to know more broadly what features this affects. Is there anything beyond autocomplete?
ACK that you tested autocomplete on the review stack, I'd ask for (1) a link so that I can verify, (2) maybe a photo to show exactly what you're referring to.
3 participants
We must tolerate syntax errors when loading an environment. Returning a
nil
EnvironmentDeclprevents us from being able to analyze theportions of the environment that were successfully parsed. This
interferes with analysis of environments that are only partially
erroneous. One important scenario this covers is autocompletion in the
face of syntax errors, which is common while editing an environment.