Skip to content

Conversation

HZooly
Copy link
Member

@HZooly HZooly commented Nov 12, 2021

As mentionned in #207

@HZooly HZooly marked this pull request as draft November 12, 2021 20:52
@HZooly
Copy link
Member Author

HZooly commented Nov 12, 2021

@smitpatelx CDN link point to a fork of the current repository, but the original one.

@smitpatelx
Copy link
Contributor

smitpatelx commented Nov 12, 2021

Check this, I already made that changes before months. I don't know what else should I do to change this. https://github.com/cdnjs/packages/blob/master/packages/v/vue-tour.json

@HZooly
Copy link
Member Author

HZooly commented Nov 12, 2021

Then I don't get why GitHub button leads to your fork, is that a bug from cdnjs?

image

@smitpatelx
Copy link
Contributor

Yes, i guess its not uptodate or it might be because of cache. They are using static files, so totally possible.

@HZooly
Copy link
Member Author

HZooly commented Nov 12, 2021

Ok right!
What about Vue Tour CSS? Don't you need it from CDN too?

@smitpatelx
Copy link
Contributor

Yes you can add that as well.
Made a PR to change description and asked question about the old link.
cdnjs/packages#893

@smitpatelx
Copy link
Contributor

smitpatelx commented Nov 12, 2021

Added css files as well. Awaiting approval from cdnjs.

@HZooly
Copy link
Member Author

HZooly commented Nov 12, 2021

Perfect! Waiting for cdnjs merge before merging this one. Thank you!

@jimaek
Copy link

jimaek commented Nov 14, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants