Skip to content

Conversation

jrgriffiniii
Copy link
Contributor

Also addresses two vulnerabilities found with bundler-audit

@jrgriffiniii jrgriffiniii requested a review from Copilot October 9, 2025 21:20
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the MediaFlux query request implementation, restructures the CircleCI configuration for parallel execution, and addresses security vulnerabilities. The changes improve code maintainability while separating different types of tests into parallel jobs for better CI performance.

  • Refactored QueryRequest class with better documentation, extracted constants, and improved method organization
  • Split CircleCI jobs into parallel executions for bundler linting/auditing, yarn operations, and testing
  • Updated Ruby version specification and addressed security vulnerabilities in dependencies

Reviewed Changes

Copilot reviewed 4 out of 7 changed files in this pull request and generated 2 comments.

File Description
app/models/mediaflux/query_request.rb Refactored with class methods for defaults, improved documentation, and better code organization
Gemfile Updated Ruby version constraint and added security vulnerability fixes for sinatra and uri gems
.tool-versions Updated Ruby version from specific 3.3.0 to general 3.3
.circleci/config.yml Restructured CI pipeline with parallel jobs for linting, auditing, and testing operations

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@jrgriffiniii jrgriffiniii self-assigned this Oct 9, 2025
@coveralls
Copy link

coveralls commented Oct 9, 2025

Coverage Status

coverage: 90.903% (-0.1%) from 91.032%
when pulling ce4ca75 on jrgriffiniii-ci-update-query-refactor
into 602a53a on main.

@jrgriffiniii jrgriffiniii force-pushed the jrgriffiniii-ci-update-query-refactor branch 3 times, most recently from ba752ff to ce4ca75 Compare October 13, 2025 15:45
@jrgriffiniii jrgriffiniii force-pushed the jrgriffiniii-ci-update-query-refactor branch from ce4ca75 to 3eba606 Compare October 15, 2025 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants