Added log message about deprecated method usage. #373
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcin-cebo
requested review from
jakub-grzesiowski,
jguz-pubnub,
kleewho and
parfeon
as code owners
jguz-pubnub
reviewed
Oct 3, 2025
| public class AnalyticsService { | ||
|
|
||
| public void trackConfigChange(String instanceId, Map<String, Object> configDetail) { | ||
| //no need to implement |
There was a problem hiding this comment.
Do we need this comment?
There was a problem hiding this comment.
This is part of codeSnippet i.e. AnalyticsService is used in MonitoringLogger that will be presented in logs.
I added this comment to indicate that this is conscious decision to left implementation empty.
What would you do in such case ? Remove comment?
jguz-pubnub
reviewed
Oct 3, 2025
| import com.pubnub.api.logging.LogMessageContent; | ||
| import com.pubnub.api.logging.LogMessageType; | ||
|
|
||
| public class MonitoringLogger implements CustomLogger { |
There was a problem hiding this comment.
What's the purpose of this logger?
There was a problem hiding this comment.
This is code snippet that will be used in docs
jguz-pubnub
reviewed
Oct 3, 2025
| timestamp: String, | ||
| location: String? | ||
| ) { | ||
| // no need to implement |
There was a problem hiding this comment.
The same here, do we need thee // no need to implement comments?
jguz-pubnub
reviewed
Oct 3, 2025
| } | ||
|
|
||
| override fun debug(message: LogMessage) { | ||
| // todo remove |
There was a problem hiding this comment.
Good catch. I will remove it.
jguz-pubnub
approved these changes
Oct 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.