Feat: Allow invocation of the emscripten_notify_memory_growth hostcall. #461
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rachgreen33
requested review from
PiotrSikora,
leonm1,
martijneken and
mpwarres
as code owners
Suggest adding to PR description: "Allowlisting this function is needed in order to make use of a smaller emscripten INITIAL_HEAP setting." |
mpwarres
approved these changes
Oct 22, 2025
PiotrSikora
approved these changes
Oct 23, 2025
| // logging (stdout/stderr) | ||
| "wasi_unstable.fd_write", "wasi_snapshot_preview1.fd_write", | ||
| // emscripten | ||
| "env.emscripten_notify_memory_growth", |
There was a problem hiding this comment.
Style: I'd move this at the top, to avoid intermixing env.* with wasi_* in the list.
LGTM otherwise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The emscripten_notify_memory_growth function is invoked by emscripten when it grows the heap. Allowlisting this function is needed in order to make use of a smaller emscripten INITIAL_HEAP setting