Skip to content

Conversation

wipfli
Copy link
Collaborator

@wipfli wipfli commented May 27, 2025

Fixes the parks issue in Amsterdam reported in #433

"forest",
"scrub",
"grassland",
"grass",
"glacier",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We forgot this one in the past. Now high-zoom glaciers are visible again. Maybe I should add a render test for this...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think the render test is most useful for this class of issue, but do we have enough data in the CI sample data?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not yet but I an create a slice

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a render test for glaciers

Copy link

sonarqubecloud bot commented Jun 2, 2025

@jgillich
Copy link

👍

FWIW this issue extends far beyond Amsterdam, the whole Swabian Jura is rendered as a park, even cities. Before and after this change:

Screenshot From 2025-08-19 19-20-00Screenshot From 2025-08-19 19-17-18

["get", "kind"],
["literal", ["wood", "nature_reserve", "forest"]],
],
t.wood_b,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just noticed that this removes the use of the wood color. Was that intentional? Seems like a useful distinction to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants