Don't recompute when dependent signals come back to previous values used for last computation #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This is a very interesting patch! I'm not ready to land it yet, as the memory usage tradeoff that @shaylew is not obvious. Let's discuss these alternatives in an issue. It's really excellent to have these alternative semantics implemented in a branch, for comparison. |
This was referenced Jun 6, 2024
divdavem
force-pushed
the
recomputeLess
branch
from
c3c116a to
49e85fe
Compare
…sed for last computation
divdavem
force-pushed
the
recomputeLess
branch
from
49e85fe to
9c27b8d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements this suggestion to avoid triggering useless re-computations when dependent signals come back to their previous values used for last computation. It includes a cache of calls to the equals function to avoid calling multiple times the equals function for the same comparison.