Skip to content

Conversation

longlene
Copy link

  1. init:stop should be after eval expression
  2. erl_interface is deprected

init:stop should be after eval expression
@JenniferZh90
Copy link

Can this one being merged?

@NelsonVides
Copy link
Member

@longlene is this PR still valid? What do you mean by erl_interface being deprecated, and if so, how can we remove it entirely? Please rebase the branch on top of the latest master if you'd have some time :)

@longlene
Copy link
Author

@NelsonVides Yes, the erl_interface is already deleted from OTP-24, the simple fix is just removing the reference of this library, otherwise, it cannot be built with a newer OTP.

@NelsonVides
Copy link
Member

I've ran master on both OTP27 and OTP28 in both ubuntu and macos and it "just runs ok", the package builds and metrics are collected fine. Where did you reproduce the issue?

Also, in your changes I've seen there's only the include reference removed, but there are still more erl_interface ones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants