Add request/response body size histograms #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds two new Prometheus histograms for measuring request and response body sizes in bytes: - cowboy_request_body_size_bytes - cowboy_response_body_size_bytes Both metrics use the same labels as other request metrics and default buckets range from 0 to 16 MiB.
kivra-adalin
force-pushed
the
push-kvrsykllwxyr
branch
from
f44a1ec to
5a223c0
Compare
|
Oops, it's from me but opened the PR with my work account by mistake 😛 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds two new Prometheus histograms for measuring request and response body sizes in bytes:
cowboy_request_body_size_bytescowboy_response_body_size_bytesBoth metrics use the same labels as other request metrics and default buckets range from 0 to 16 MiB.
Open questions:
rebar3 ctdidn't run anything.prometheus_bucket?