Skip to content

Add support for AWS/EKS namespace #1760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+10 −0
Open

Add support for AWS/EKS namespace #1760

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions pkg/config/services.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,6 +430,16 @@ var SupportedServices = serviceConfigs{
regexp.MustCompile("file-system/(?P<FileSystemId>[^/]+)"),
},
},
{
Namespace: "AWS/EKS",
Alias: "eks",
ResourceFilters: []*string{
aws.String("eks:cluster"),
},
DimensionRegexps: []*regexp.Regexp{
regexp.MustCompile(":cluster/(?P<ClusterName>[^/]+)$"),
},
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the difference with ContainerInsights a few lines above?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ContainerInsights is a namespace for containerized application and worker node metrics that is not available by default for EKS clusters, as it requires an add-on to be installed.

AWS/EKS is a standard namespace that provides metrics from a Kubernetes cluster control plane.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally all the namespaces listed here should be supported?

{
Namespace: "AWS/ELB",
Alias: "elb",
Expand Down