WIP: Update vendored gopls to version 0.4.2 #181
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tobias Guggenmos <[email protected]>
Signed-off-by: Tobias Guggenmos <[email protected]>
Signed-off-by: Tobias Guggenmos <[email protected]>
Signed-off-by: Tobias Guggenmos <[email protected]>
Signed-off-by: Tobias Guggenmos <[email protected]>
Signed-off-by: Tobias Guggenmos <[email protected]>
Signed-off-by: Tobias Guggenmos <[email protected]>
Signed-off-by: Tobias Guggenmos <[email protected]>
Signed-off-by: Tobias Guggenmos <[email protected]>
Signed-off-by: Tobias Guggenmos <[email protected]>
Signed-off-by: Tobias Guggenmos <[email protected]>
The code was unused and broken due to previous API changes anyway. If someone needs websocket support, it's a good idea to reimplement it from scratch. Signed-off-by: Tobias Guggenmos <[email protected]>
Signed-off-by: Tobias Guggenmos <[email protected]>
Signed-off-by: Tobias Guggenmos <[email protected]>
slrtbtfs
added a commit
that referenced
this pull request
Jul 7, 2020
The websocket module was never finished and due to API changes in various places, doesn't work in it's current form. Also it's incompatible with #181. If someone wants to solve #55, it's better to start over. Signed-off-by: Tobias Guggenmos <[email protected]>
slrtbtfs
added a commit
that referenced
this pull request
Jul 17, 2020
Fixes #189. This fixes some unchecked pointer accesses in the cache package. Independently of how errors are handled, these checks should be in place. Proper error handling as discussed in #189 and #181 can happen separately. Signed-off-by: Tobias Guggenmos <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.