Skip to content

Conversation

mittman
Copy link

@mittman mittman commented Mar 23, 2018

Add build instructions for non-Gentoo users

Copy link
Member

@mgorny mgorny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your submission. However, I'd like to point out that I personally am against Markdown, and prefer RST or plain text.

Create efficient deltas (patches) between two SquashFS images

## Building from source
This project uses [autotools](http://inti.sourceforge.net/tutorial/libinti/autotoolsproject.html)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm against linking to some project's documentation that is in no way related to this project or upstream autotools.


```bash
$ git clone https://github.com/mgorny/squashdelta.git
$ cd squashdelta
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's little activity in git, and there is a proper release .tar (in 'Releases') which is strongly recommended over it.


```bash
$ aclocal
$ autoconf
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those two are covered by autoreconf.

```bash
$ aclocal
$ autoconf
$ touch AUTHORS NEWS README ChangeLog
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not needed at all.

$ aclocal
$ autoconf
$ touch AUTHORS NEWS README ChangeLog
$ mkdir build-aux
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably unnecessary.

$ touch AUTHORS NEWS README ChangeLog
$ mkdir build-aux
$ autoreconf --install
$ automake --add-missing
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is already done by autoreconf.

```

```bash
$ ./configure --prefix=/opt/bin
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a weird prefix to suggest. Please remember that users take this seriously, and they're going to end up installing in this weird location.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants