Refactor component-vcluster to use helm chart #87
Conversation
TheBigLee
force-pushed
the
refactor
branch
9 times, most recently
from
742cc2a to
31fed67
Compare
TheBigLee
added
enhancement
TheBigLee
force-pushed
the
refactor
branch
2 times, most recently
from
10df627 to
002af82
Compare
There was a problem hiding this comment.
Can't really properly review this since there's almost no context for the changes (i.e. it's hard to tell if the changes are correct/make sense without any information about the why).
I assume https://github.com/projectsyn/component-vcluster/blob/master/docs/modules/ROOT/pages/how-tos/oidc.adoc and https://github.com/projectsyn/component-vcluster/blob/master/docs/modules/ROOT/pages/tutorials/installation-openshift.adoc are outdated as well, given all the changes in this PR.
| | kubectl apply -f - -oyaml | ||
| echo "Patching route..." | ||
|
|
||
| kubectl -n "$NAMESPACE" patch route "$route_name" --patch-file "${patch_file}" |
There was a problem hiding this comment.
Where does this route come from? Is it safe to patch it once in a while?
There was a problem hiding this comment.
We might be able to do this more elegantly with espejote nowadays...
There was a problem hiding this comment.
The route is generated from the ingress that is created by the helm chart
There was a problem hiding this comment.
The openshjift API-server already translates ingress to route?
|
|
||
| ==== `syncer.additional_args` | ||
|
|
||
| This parameter is now obsolete. |
There was a problem hiding this comment.
What's replacing this parameter? Are we setting these directly in helm values?
| role: | ||
| extraRules: | ||
| - apiGroups: [""] | ||
| resources: ["endpoints/restricted"] |
There was a problem hiding this comment.
Interesting context openshift/kubernetes#899 (comment)
TheBigLee
force-pushed
the
refactor
branch
7 times, most recently
from
ba0aa9e to
6446ca7
Compare
This will refactor the component completely to use the latest official helm chart. Due to this change, there are a few breaking changes that will have to be handled carefully. Check the docs for more information Signed-off-by: Nicolas Bigler <[email protected]>
Checklist
changelog.
The PR has a meaningful description that sums up the change. It will be
linked in the changelog.
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog.