Modular neuron model #50
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Neurons are split into dynamics, input and threshold * Combined together using something resembling policy design pattern into ModularNeuron * Implemented if_curr_exp and if_cond_exp in this way
* In C++ member functions which are SYNTACTICALLY inline are inline * Static inline deprecated in C++
rowleya
reviewed
Oct 17, 2016
| static inline bool Update(MutableState &mutableState, const ImmutableState &immutableState, | ||
| S1615 excInput, S1615 inhInput, S1615 extCurrent) | ||
| static S1615 Update(MutableState &mutableState, const ImmutableState &immutableState, | ||
| S1615 inputCurrent) |
There was a problem hiding this comment.
Not sure that I would merge these currents prior to this point. Keeping them separate allows the possibility of having a merged-in-conductance model for example (we would have to provide a Raw input type which would look very like the Curr, and a Passive synapse type)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@rowleya this is my reimagining of the modular neuron stuff using templates. I'm pretty happy with it aside from the fact that it seems to be making the adaptive neuron way slower for no reason I can yet understand.