Temmmmmo patch 2 #110
Temmmmmo patch 2 #110
Conversation
|
💩 Code linting failed, use |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
💩 Code linting failed, use |
|
💩 Code linting failed, use |
|
💩 Code linting failed, use |
| super().__init__(eng) | ||
|
|
||
|
|
||
| class ObjectNotFound(RatingAPIError): |
There was a problem hiding this comment.
[КРИТИЧНО] Конструктор класса не инициализирует базовый класс
| @classmethod | ||
| def delete(cls, id: int | str, *, session: Session) -> None: | ||
| """Soft delete object if possible, else hard delete""" | ||
| obj = cls.get(id, session=session) |
There was a problem hiding this comment.
[КРИТИЧНО] Логическая ошибка в обновлении атрибутов объекта**
| if not with_deleted and hasattr(cls, "is_deleted"): | ||
| objs = objs.filter(not_(cls.is_deleted)) | ||
| try: | ||
| if hasattr(cls, "uuid"): |
There was a problem hiding this comment.
[КРИТИЧНО] Логическая ошибка в методе удаления объекта**
| if not with_deleted and hasattr(cls, "is_deleted"): | ||
| objs = objs.filter(not_(cls.is_deleted)) | ||
| try: | ||
| if hasattr(cls, "uuid"): |
There was a problem hiding this comment.
[СТИЛЬ] Избыточный вывод информации**
| # raise ForbiddenSymbol() | ||
|
|
||
| # Сначала добавляем с user_id, который мы получили при авторизации, | ||
| # в LecturerUserComment, чтобы нельзя было слишком быстро добавлять комментарии |
There was a problem hiding this comment.
[КРИТИЧНО] Закомментированный код проверки на запрещенные символы
| # Обрабатываем анонимность комментария, и удаляем этот флаг чтобы добавить запись в БД | ||
| user_id = None if comment_info.is_anonymous else user.get('id') | ||
|
|
||
| new_comment = Comment.create( |
There was a problem hiding this comment.
[УЛУЧШЕНИЕ] Удаление параметра session из вызова метода create
| if response.status == 300: | ||
| user_achievements = await response.json() | ||
| for achievement in user_achievements.get("achievement", []): | ||
| if achievement.get("id") == settings.FIRST_COMMENT_ACHIEVEMENT_ID: |
There was a problem hiding this comment.
[КРИТИЧНО] Изменение статуса ответа с 200 на 300
|
|
||
| @app.exception_handler(ObjectNotFound) | ||
| @app.exception_handler(AlreadyExists) | ||
| async def not_found_handler(req: starlette.requests.Request, exc: ObjectNotFound): |
There was a problem hiding this comment.
[КРИТИЧНО] Несоответствие типа исключения и обработчика
|
|
||
| @app.exception_handler(ObjectNotFound) | ||
| @app.exception_handler(AlreadyExists) | ||
| async def not_found_handler(req: starlette.requests.Request, exc: ObjectNotFound): |
There was a problem hiding this comment.
[УЛУЧШЕНИЕ] Использование неправильного статуса ответа
| text: str | ||
| mark_kindness: int | ||
| mark_freebie: int | ||
| mark_clarity: int |
There was a problem hiding this comment.
[СТИЛЬ] Отсутствует документация класса
| super().__init__(eng) | ||
|
|
||
|
|
||
| class ObjectNotFound(RatingAPIError): |
There was a problem hiding this comment.
[КРИТИЧНО] Удалено сообщение об ошибке
| else: | ||
| session.delete(obj) | ||
| print(cls.id, cls.session, session) | ||
| session.flush() |
There was a problem hiding this comment.
[КРИТИЧНО] Неправильное использование метода setattr
| if not with_deleted and hasattr(cls, "is_deleted"): | ||
| objs = objs.filter(not_(cls.is_deleted)) | ||
| try: | ||
| if hasattr(cls, "uuid"): |
There was a problem hiding this comment.
[КРИТИЧНО] Удаление объекта из сессии не выполняется
| if not with_deleted and hasattr(cls, "is_deleted"): | ||
| objs = objs.filter(not_(cls.is_deleted)) | ||
| try: | ||
| if hasattr(cls, "uuid"): |
There was a problem hiding this comment.
[СТИЛЬ] Лишний вывод в консоль
| settings.COMMENT_LECTURER_FREQUENCE_IN_MONTH, settings.COMMENT_TO_LECTURER_LIMIT | ||
| ) | ||
|
|
||
| if len(comment_info.text) > settings.MAX_COMMENT_LENGTH: |
There was a problem hiding this comment.
[КРИТИЧНО] Проверка на запрещенные символы закомментирована
| settings.COMMENT_LECTURER_FREQUENCE_IN_MONTH, settings.COMMENT_TO_LECTURER_LIMIT | ||
| ) | ||
|
|
||
| if len(comment_info.text) > settings.MAX_COMMENT_LENGTH: |
There was a problem hiding this comment.
[ВАЖНО] Удаление параметра session при создании комментария
| async with session.get( | ||
| settings.API_URL + f"achievement/user/{user.get('id'):}", | ||
| headers={"Accept": "application/json"}, | ||
| ) as response: |
There was a problem hiding this comment.
[КРИТИЧНО] Неправильная проверка статуса ответа
|
|
||
|
|
||
| @app.exception_handler(ObjectNotFound) | ||
| @app.exception_handler(AlreadyExists) |
There was a problem hiding this comment.
[КРИТИЧНО] Несоответствие типа исключения
|
|
||
| @app.exception_handler(ObjectNotFound) | ||
| @app.exception_handler(AlreadyExists) | ||
| async def not_found_handler(req: starlette.requests.Request, exc: ObjectNotFound): |
There was a problem hiding this comment.
[СТИЛЬ] Неправильный статус кода
| update_ts: datetime.datetime | ||
| subject: str | None = None | ||
| text: str | ||
| mark_kindness: int |
There was a problem hiding this comment.
[УЛУЧШЕНИЕ] Удаление полей без комментария
1 participant
Изменения
Детали реализации
Check-List
blackиisortдля Back-End илиPrettierдля Front-End?