chore(eslint): convert eslint config to flat config #376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csouchet
added
the
chore
|
♻️ PR Preview c1d054b has been successfully destroyed since this PR has been closed.
🤖 By surge-preview |
csouchet
force-pushed
the
chore/convert_eslint_config_to_flat
branch
from
079d073 to
55ed97c
Compare
csouchet
force-pushed
the
chore/convert_eslint_config_to_flat
branch
from
55ed97c to
4ad406d
Compare
|
# Conflicts: # package-lock.json # package.json
tbouffard
requested changes
Jun 16, 2025
tbouffard
reviewed
Jun 16, 2025
tbouffard
reviewed
Jun 18, 2025
| this.model = bpmnVisualization.graph.model; | ||
| } | ||
|
|
||
| /* eslint-disable jest/no-standalone-expect -- util code, including expect calls */ |
There was a problem hiding this comment.
question: why is this removed?
# Conflicts: # .eslintrc.cjs # package-lock.json # package.json
tbouffard
reviewed
Jun 18, 2025
tbouffard
reviewed
Jun 18, 2025
…uration is at the project root
jest: ensure recommended and style rules are enabled + apply jsdom config correctly test files: - use right glob - centralize config remove extra unicorn configuration that didn't exist in the former configuration The extra configuration came from bpmn-visualization and had been copy/paste here by mistake
# Conflicts: # package-lock.json # packages/addons/package.json
tbouffard
reviewed
Jun 19, 2025
|
tbouffard
approved these changes
Jun 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.