Skip to content

Confirmation for Overwrite #858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Confirmation for Overwrite #858

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
81 changes: 67 additions & 14 deletions src/uimenu.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -992,23 +992,76 @@ void CUIMenu::EditOPParameter (CUIMenu *pUIMenu, TMenuEvent Event)

void CUIMenu::SavePerformance (CUIMenu *pUIMenu, TMenuEvent Event)
{
if (Event != MenuEventUpdate)
{
return;
// Add confirmation before overwriting a performance
static bool bOverwriteMode = false;
static bool bConfirmOverwrite = false;

if (pUIMenu->m_nCurrentParameter == 0) { // Overwrite
if (!bOverwriteMode) {
if (Event == MenuEventUpdate) {
bOverwriteMode = true;
bConfirmOverwrite = false;
// Show confirmation dialog with performance name
std::string perfName = pUIMenu->m_pMiniDexed->GetPerformanceName(pUIMenu->m_pMiniDexed->GetActualPerformanceID());
pUIMenu->m_pUI->DisplayWrite("", "Overwrite?", perfName.c_str(), false, false);
return;
}
if (Event == MenuEventStepDown) {
bConfirmOverwrite = false;
std::string perfName = pUIMenu->m_pMiniDexed->GetPerformanceName(pUIMenu->m_pMiniDexed->GetActualPerformanceID());
pUIMenu->m_pUI->DisplayWrite("", "Overwrite?", perfName.c_str(), false, false);
return;
}
if (Event == MenuEventStepUp) {
bConfirmOverwrite = true;
std::string perfName = pUIMenu->m_pMiniDexed->GetPerformanceName(pUIMenu->m_pMiniDexed->GetActualPerformanceID());
pUIMenu->m_pUI->DisplayWrite("", "Overwrite?", (perfName + " [Yes]").c_str(), false, false);
return;
}
if (Event == MenuEventSelect) {
if (bConfirmOverwrite) {
bOverwriteMode = false;
bConfirmOverwrite = false;
bool bOK = pUIMenu->m_pMiniDexed->SavePerformance(false);
const char *pMenuName =
pUIMenu->m_MenuStackParent[pUIMenu->m_nCurrentMenuDepth-1]
[pUIMenu->m_nMenuStackItem[pUIMenu->m_nCurrentMenuDepth-1]].Name;
pUIMenu->m_pUI->DisplayWrite (pMenuName,
pUIMenu->m_pParentMenu[pUIMenu->m_nCurrentMenuItem].Name,
bOK ? "Completed" : "Error",
false, false);
CTimer::Get ()->StartKernelTimer (MSEC2HZ (1500), TimerHandler, 0, pUIMenu);
return;
} else {
bOverwriteMode = false;
bConfirmOverwrite = false;
Event = MenuEventUpdate;
}
}
return;
}
}

bool bOK = pUIMenu->m_pMiniDexed->SavePerformance (pUIMenu->m_nCurrentParameter == 1);

const char *pMenuName =
pUIMenu->m_MenuStackParent[pUIMenu->m_nCurrentMenuDepth-1]
[pUIMenu->m_nMenuStackItem[pUIMenu->m_nCurrentMenuDepth-1]].Name;

pUIMenu->m_pUI->DisplayWrite (pMenuName,
pUIMenu->m_pParentMenu[pUIMenu->m_nCurrentMenuItem].Name,
bOK ? "Completed" : "Error",
false, false);
if (pUIMenu->m_nCurrentParameter == 2) { // Save as default, no confirmation needed
if (Event != MenuEventUpdate)
{
bool bOK = pUIMenu->m_pMiniDexed->SavePerformance(true);
const char *pMenuName =
pUIMenu->m_MenuStackParent[pUIMenu->m_nCurrentMenuDepth-1]
[pUIMenu->m_nMenuStackItem[pUIMenu->m_nCurrentMenuDepth-1]].Name;
pUIMenu->m_pUI->DisplayWrite (pMenuName,
pUIMenu->m_pParentMenu[pUIMenu->m_nCurrentMenuItem].Name,
bOK ? "Completed" : "Error",
false, false);
CTimer::Get ()->StartKernelTimer (MSEC2HZ (1500), TimerHandler, 0, pUIMenu);
}
return;
}

CTimer::Get ()->StartKernelTimer (MSEC2HZ (1500), TimerHandler, 0, pUIMenu);
// New (handled by InputTxt)
if (pUIMenu->m_nCurrentParameter == 1) {
return;
}
}

string CUIMenu::GetGlobalValueString (unsigned nParameter, int nValue)
Expand Down