Skip to content

Normalize reverb time to sample rate #838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Normalize reverb time to sample rate #838

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
808e8a7
Normalize reverb time to sample rate
probonopd Apr 18, 2025
8dbf160
Use 48 kHz for the scaling
probonopd Apr 18, 2025
827d9cd
rv_time = rv_time_k * (48000.0f / m_samplerate);
probonopd Apr 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/effect_platervbstereo.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@ const int16_t AudioWaveformSine[257] = {

AudioEffectPlateReverb::AudioEffectPlateReverb(float32_t samplerate)
{
m_samplerate = samplerate;
input_attn = 0.5f;
in_allp_k = INP_ALLP_COEFF;

Expand Down Expand Up @@ -200,7 +201,7 @@ void AudioEffectPlateReverb::doReverb(const float32_t* inblockL, const float32_t
}
cleanup_done = false;

rv_time = rv_time_k;
rv_time = rv_time_k * (48000.0f / m_samplerate);

for (uint16_t i=0; i < len; i++)
{
Expand Down
1 change: 1 addition & 0 deletions src/effect_platervbstereo.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,7 @@ class AudioEffectPlateReverb
bool bypass = false;
float32_t reverb_level;
float32_t input_attn;
float32_t m_samplerate; // store the sample rate

float32_t in_allp_k; // input allpass coeff
float32_t in_allp1_bufL[224]; // input allpass buffers
Expand Down