Fix: Unittests failing because of existing buckets + inconsistency with firebase.rules #359
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There are a couple changes, we had to make to pass the
yarn test:produnittest.provided name is already in use. This happened on bucket creation if the bucket already existed. Apperently the after test cleanup did not delete buckets correctly. Fixing that did not seem right to me, because interrupting a test run in the middle should not make future test runs fail. I was unable to get the cleanup work in the test setup phase. So the best fix, I could find is not throwing errors on recreating existing buckets. To my understanding this is fine becaue I could not find any bucket deletion in the production code.How Has This Been Tested?
yarn test:prodChecklist: