feat: extensions schema entrypoint #5626
Conversation
CodSpeed Performance ReportMerging #5626 will not alter performanceComparing Summary
|
WASM Query Engine File Size
WASM Query Compiler File Size
|
schema-engine/core/src/extensions.rs
Outdated
|
|
||
| fn get_by_db_name_and_modifiers(&self, name: &str, modifiers: Option<&[String]>) -> Option<ExtensionTypeEntry<'_>> { | ||
| self.by_db_name_and_modifiers | ||
| .get(&(name.to_string(), modifiers.map(|m| m.to_vec()))) |
There was a problem hiding this comment.
Could we get rid of these allocations if we changed the representation from HashMap<(String, Option<Vec<String>>), usize> to something like HashMap<String, HashMap<Vec<String>, usize>>? Do we need to differentiate between None and an empty vec?
There was a problem hiding this comment.
could be worth switching to hashbrown and their Equivalent trait to avoid allocations in this function entirely
There was a problem hiding this comment.
Do we need to differentiate between None and an empty vec?
In this implementation I do, they mean different things, but we don't actually plan to support that, it's just a leftover from my initial implementation.
TML-1411