Skip to content

don't ignore errors in migrate [integration] #5591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −11
Draft

don't ignore errors in migrate [integration] #5591

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 1 addition & 11 deletions schema-engine/connectors/sql-schema-connector/src/flavour.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,17 +248,7 @@ pub(crate) trait SqlConnector: Send + Sync + Debug {
{
return Ok(Err(PersistenceNotInitializedError));
}
Err(_) => {
// TODO: this is a workaround, as currently the errors thrown by Driver Adapters do not
// match the known user-facing errors we expect.
// We should fix this in the future.
//
// This used to actually yield:
// ```
// err @ Err(_) => err?
// ```
return Ok(Err(PersistenceNotInitializedError));
}
Err(err) => return Err(err),
};

let rows = rows
Expand Down
Loading