-
Notifications
You must be signed in to change notification settings - Fork 279
fix(schema): Tolerate internal CRDB enums #5530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix(schema): Tolerate internal CRDB enums #5530
Conversation
|
|
||
// * Note: Expression Indexes can have 1 & 2 | ||
if column_index == 0 { | ||
if current_index.is_none() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise, for multi-region tables this fails on line 1452 due to the unwrap.
We filter out "hidden" columns on tables, and the multi-region configuration is hidden, but does show up in the index, therefore column_index
ends up being 1 for the the first "real" column in the index.
CodSpeed Performance ReportMerging #5530 will not alter performanceComparing Summary
|
Hi @john-privy, this sounds like a sensible approach to me, thanks! I recommend the following test setup commands:
|
Excellent and for sure! One follow-up question for you - my company was recently acquired by Stripe, and the OSS team is curious if there is a Corporate CLA we could sign, rather than per contributor? |
Friendly bump on this ask JIC, thanks! |
@john-privy We can def look into that. Should we take this up via email? If that's ok, pls shoot me a msg at gupta at prisma dot io. |
Addresses prisma/prisma#11127.
This is a barebones fix without tests to get any feedback on approach first.