Skip to content

Conversation

john-privy
Copy link

Addresses prisma/prisma#11127.

This is a barebones fix without tests to get any feedback on approach first.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.


// * Note: Expression Indexes can have 1 & 2
if column_index == 0 {
if current_index.is_none() {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, for multi-region tables this fails on line 1452 due to the unwrap.

We filter out "hidden" columns on tables, and the multi-region configuration is hidden, but does show up in the index, therefore column_index ends up being 1 for the the first "real" column in the index.

Copy link

codspeed-hq bot commented Jul 15, 2025

CodSpeed Performance Report

Merging #5530 will not alter performance

Comparing john-privy:fix/tolerate-internal-crdb_enums (1b53140) with main (cf92c4b)

Summary

✅ 11 untouched benchmarks

@jkomyno
Copy link
Contributor

jkomyno commented Jul 25, 2025

Hi @john-privy, this sounds like a sensible approach to me, thanks!
Can you push test fixes too?

I recommend the following test setup commands:

  • cargo fix
  • cargo clippy --workspace --all-features
  • make dev-cockroach_23_1
  • export TEST_DATABASE_URL="postgresql://prisma@localhost:26260"
  • UPDATE_EXPECT=1 cargo test --package sql-introspection-tests -- --show-output --test-threads=1

@john-privy
Copy link
Author

Hi @john-privy, this sounds like a sensible approach to me, thanks! Can you push test fixes too?

I recommend the following test setup commands:

Excellent and for sure!

One follow-up question for you - my company was recently acquired by Stripe, and the OSS team is curious if there is a Corporate CLA we could sign, rather than per contributor?

@john-privy
Copy link
Author

Hi @john-privy, this sounds like a sensible approach to me, thanks! Can you push test fixes too?
I recommend the following test setup commands:

Excellent and for sure!

One follow-up question for you - my company was recently acquired by Stripe, and the OSS team is curious if there is a Corporate CLA we could sign, rather than per contributor?

Friendly bump on this ask JIC, thanks!

@gniting
Copy link

gniting commented Aug 18, 2025

One follow-up question for you - my company was recently acquired by Stripe, and the OSS team is curious if there is a Corporate CLA we could sign, rather than per contributor?

@john-privy We can def look into that. Should we take this up via email? If that's ok, pls shoot me a msg at gupta at prisma dot io.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants