Skip to content

Conversation

liuliu-dev
Copy link
Contributor

The Storybook examples were importing ActionList.Item from deprecated ActionList components. The .TruncatedText CSS was not working properly because the deprecated Item doesn't have proper width constraints. Updated to use current ActionList components.

Closes #5773

Rollout strategy

  • None, a storybook issue.

@liuliu-dev liuliu-dev added skip changeset This change does not need a changelog integration-tests: skipped manually Changes in this PR do not require an integration test labels Aug 26, 2025
Copy link

changeset-bot bot commented Aug 26, 2025

⚠️ No Changeset found

Latest commit: b082fd3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Aug 26, 2025

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 89.84 KB (0%)
packages/react/dist/browser.umd.js 89.99 KB (0%)

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes text truncation issues in SelectPanel Storybook examples by migrating from deprecated ActionList components to current ones. The truncation wasn't working properly because the deprecated components lacked proper width constraints.

  • Migrated imports from deprecated ActionList components to current ActionList implementation
  • Replaced custom CSS truncation with built-in ActionList.Description truncate functionality
  • Removed now-unnecessary custom CSS truncation styles

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
packages/react/src/SelectPanel/SelectPanel.examples.stories.tsx Updates imports and item renderer to use current ActionList components with proper truncation
packages/react/src/SelectPanel/SelectPanel.examples.stories.module.css Removes custom truncation CSS that's no longer needed

@hectahertz hectahertz added this pull request to the merge queue Aug 27, 2025
Merged via the queue into main with commit 938b375 Aug 27, 2025
43 checks passed
@hectahertz hectahertz deleted the liuliu/fix-selectpanel-storybook-truncate-example branch August 27, 2025 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration-tests: skipped manually Changes in this PR do not require an integration test skip changeset This change does not need a changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants