Skip to content

Conversation

llastflowers
Copy link
Contributor

@llastflowers llastflowers commented Aug 26, 2025

Closes https://github.com/github/primer/issues/5781

Current sx usage: 1

❌ Still need to separately update github-ui components to use @primer/styled-react

Changelog

Removed

Remove support for sx from the CircleOcticon component, and associated stories, docs, and tests

Rollout strategy

  • Major release; if selected, include a written rollout or migration plan

We are using the @primer/styled-react component to mitigate removing sx usage. We will make sure usage is updated upstream before merging.

Merge checklist

@llastflowers llastflowers self-assigned this Aug 26, 2025
Copy link

changeset-bot bot commented Aug 26, 2025

🦋 Changeset detected

Latest commit: ea205d3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@primer/react Major
@primer/styled-react Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Aug 26, 2025
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

Copy link
Contributor

github-actions bot commented Aug 26, 2025

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 89.86 KB (+0.11% 🔺)
packages/react/dist/browser.umd.js 90.13 KB (+0.14% 🔺)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant