Skip to content

Conversation

liuliu-dev
Copy link
Contributor

@liuliu-dev liuliu-dev commented Aug 25, 2025

Closes #5769

Changelog

Removed

Removed sx props from deprecated Tooltip and TooltipV2

Rollout strategy

  • Major release; if selected, include a written rollout or migration plan

Copy link

changeset-bot bot commented Aug 25, 2025

🦋 Changeset detected

Latest commit: 925c38e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@primer/react Major
@primer/styled-react Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Aug 25, 2025
Copy link
Contributor

github-actions bot commented Aug 25, 2025

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 89.86 KB (+0.02% 🔺)
packages/react/dist/browser.umd.js 89.95 KB (-0.06% 🔽)

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the deprecated sx prop support from both Tooltip and TooltipV2 components as part of a major release. The changes align with the design system's move away from styled-system props in favor of more maintainable styling approaches.

Key Changes

  • Removed sx prop from both Tooltip and TooltipV2 component type definitions
  • Replaced BoxWithFallback with native span element in TooltipV2
  • Cleaned up styled-components integration in legacy Tooltip

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/react/src/TooltipV2/Tooltip.tsx Removed SxProp import and type, replaced BoxWithFallback with span
packages/react/src/TooltipV2/Tooltip.docs.json Removed sx prop from component documentation
packages/react/src/Tooltip/Tooltip.tsx Removed SxProp type and sx function from styled-component
packages/react/src/Tooltip/Tooltip.docs.json Removed sx prop from component documentation
.changeset/pink-rockets-win.md Added changeset entry for major version bump

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant