-
Notifications
You must be signed in to change notification settings - Fork 624
Remove sx
props and BoxWithFallback
from TooltipV2
and Tooltip
#6667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 925c38e The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes the deprecated sx
prop support from both Tooltip
and TooltipV2
components as part of a major release. The changes align with the design system's move away from styled-system props in favor of more maintainable styling approaches.
Key Changes
- Removed
sx
prop from bothTooltip
andTooltipV2
component type definitions - Replaced
BoxWithFallback
with nativespan
element inTooltipV2
- Cleaned up styled-components integration in legacy
Tooltip
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
packages/react/src/TooltipV2/Tooltip.tsx |
Removed SxProp import and type, replaced BoxWithFallback with span |
packages/react/src/TooltipV2/Tooltip.docs.json |
Removed sx prop from component documentation |
packages/react/src/Tooltip/Tooltip.tsx |
Removed SxProp type and sx function from styled-component |
packages/react/src/Tooltip/Tooltip.docs.json |
Removed sx prop from component documentation |
.changeset/pink-rockets-win.md |
Added changeset entry for major version bump |
Closes #5769
sx
props withTooltip
.Changelog
Removed
Removed
sx
props from deprecatedTooltip
andTooltipV2
Rollout strategy