Fix #7521 – use composedPath in MultiSelect to detect target in shadow root events #8108
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defect Fixes
Fixes #7521
When
MultiSelect
is used inside a shadow root, clicks inside the overlay are not detected correctly. The existingisOutsideClicked
method relies onevent.target
andcontains()
, which don’t behave as expected across shadow DOM boundaries. As a result, interactions inside the overlay (e.g., clicking the filter input or selecting an option) are treated as outside clicks, causing the overlay to close unexpectedly.In contrast, the
Select
component already handles this properly by usingevent.composedPath()
to determine whether the click originated from inside the component or its overlay.Suggested fix
Unify the behavior between
MultiSelect
andSelect
by replacing theisOutsideClicked
check with logic based onevent.composedPath()
. This ensures correct event target detection both in the light DOM and shadow DOM contexts.