refactor: source cache into a separate crate #1860
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolved conflicts: - Combined workspace members (rattler_git, rattler_build_source_cache, rattler_build_recipe_generator) - Updated rattler dependency versions to match main - Kept source cache refactoring with cache_adapter instead of duplicate fetch_source function - Regenerated Cargo.lock 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
wolfv
changed the title
wolfv
changed the title
nichmor
reviewed
Oct 10, 2025
| authors.workspace = true | ||
| license.workspace = true | ||
| repository.workspace = true | ||
| description = "Source cache management for rattler-build" |
There was a problem hiding this comment.
only for GIT and url right?
There was a problem hiding this comment.
yeah but we don't cache "path" sources (as they are on disk already) :)
|
|
||
| ## Usage | ||
|
|
||
| ```rust |
There was a problem hiding this comment.
should we make it as a doctest for example in lib.rs?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR splits up
rattler-buildto add additional crates:rattler_build_source_cachecontains a module to fetch and cache sources (URL and Git).rattler_gitis a copy frompixi_git(which comes fromuv_git) and takes care of checking out git repositories. This should ideally – if things work out – make it's way torattler.