- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 129
Add tutorial of free flow over porous media #678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for porting this case from the adapter repository. After correcting the executable name in free-flow-dumux/appl/CMakeLists.txt, I was able to run the case. The results look as expected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please try to remove the random circular entity that is in the FreeFlow participant box?
| # Name of the module | ||
| Module: porous-media-dumux | ||
| Version: 1.0 | ||
| Maintainer: [email protected] | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the other participant, you have provided an IPVS email ID.
| # Check if no input argument was provided | ||
| if [ -z "$*" ] ; then | ||
| echo "No input argument provided. Free flow solver is launched in serial" | ||
| ./free_flow_dumux params.input | ||
| fi | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this check necessary?
| # Check if no input argument was provided | ||
| if [ -z "$*" ] ; then | ||
| echo "No input argument provided. Porous medium solver is launched in serial" | ||
| ./porous_media_dumux params.input | ||
| fi | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar to above.
| ./free_flow_dumux params.input | ||
| fi | ||
|  | ||
| while getopts ":sp" opt; do | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If no parallel execution is possible, we can simply remove this option.
|  | ||
| ## Running the simulation | ||
|  | ||
| You can find the corresponding `run.sh`script for running the case in the folders corresponding to the solvers you want to use. | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| You can find the corresponding `run.sh`script for running the case in the folders corresponding to the solvers you want to use. | |
| Each participant has a `run.sh` script. | 
| ./run.sh | ||
| ``` | ||
|  | ||
| So far only serial execution is supported for this tutorial, which takes less than two minutes to finish. | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| So far only serial execution is supported for this tutorial, which takes less than two minutes to finish. | |
| Participants can be executed only in serial. Parallel execution is not supported. The case takes approximately two minutes to finish. | 
|  | ||
| ## Post-processing | ||
|  | ||
| The VTU files from both solvers could be rendered and inspected with ParaView. | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| The VTU files from both solvers could be rendered and inspected with ParaView. | |
| Both participants create export VTU files, which can be viewed using ParaView. | 
| ## Further information | ||
|  | ||
| The simulation is stationary and the results of the pressure and the velocity fields are as follows: | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| ## Further information | |
| The simulation is stationary and the results of the pressure and the velocity fields are as follows: | |
| The results of the pressure and the velocity fields are as follows: | 
| add_executable(porous_media_dumux main.cc) | ||
| target_compile_definitions(porous_media_dumux PUBLIC "ENABLEMONOLITHIC=0") | ||
| target_link_libraries(porous_media_dumux PRIVATE dumux-precice) | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| add_executable(porous_media_dumux main.cc) | |
| target_compile_definitions(porous_media_dumux PUBLIC "ENABLEMONOLITHIC=0") | |
| target_link_libraries(porous_media_dumux PRIVATE dumux-precice) | |
| add_executable(free_flow_dumux main.cc) | |
| target_compile_definitions(free_flow_dumux PUBLIC "ENABLEMONOLITHIC=0") | |
| target_link_libraries(free_flow_dumux PRIVATE dumux-precice) | 
Motivation: precice/dumux-adapter#52.
Checklist:
changelog-entries/<PRnumber>.md.