Skip to content

Conversation

@Fujikawas
Copy link
Member

Motivation: precice/dumux-adapter#52.

Checklist:

  • I added a summary of any user-facing changes (compared to the last release) in the changelog-entries/<PRnumber>.md.
  • I will remember to squash-and-merge, providing a useful summary of the changes of this PR.

@Fujikawas Fujikawas self-assigned this Oct 27, 2025
@Fujikawas Fujikawas marked this pull request as draft October 27, 2025 10:23
@Fujikawas Fujikawas marked this pull request as ready for review October 30, 2025 12:53
@Fujikawas Fujikawas requested a review from IshaanDesai October 30, 2025 12:54
Copy link
Member

@IshaanDesai IshaanDesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for porting this case from the adapter repository. After correcting the executable name in free-flow-dumux/appl/CMakeLists.txt, I was able to run the case. The results look as expected.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please try to remove the random circular entity that is in the FreeFlow participant box?

# Name of the module
Module: porous-media-dumux
Version: 1.0
Maintainer: [email protected]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the other participant, you have provided an IPVS email ID.

Comment on lines +9 to +13
# Check if no input argument was provided
if [ -z "$*" ] ; then
echo "No input argument provided. Free flow solver is launched in serial"
./free_flow_dumux params.input
fi
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this check necessary?

Comment on lines +9 to +13
# Check if no input argument was provided
if [ -z "$*" ] ; then
echo "No input argument provided. Porous medium solver is launched in serial"
./porous_media_dumux params.input
fi
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to above.

./free_flow_dumux params.input
fi

while getopts ":sp" opt; do
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If no parallel execution is possible, we can simply remove this option.


## Running the simulation

You can find the corresponding `run.sh`script for running the case in the folders corresponding to the solvers you want to use.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
You can find the corresponding `run.sh`script for running the case in the folders corresponding to the solvers you want to use.
Each participant has a `run.sh` script.

./run.sh
```

So far only serial execution is supported for this tutorial, which takes less than two minutes to finish.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
So far only serial execution is supported for this tutorial, which takes less than two minutes to finish.
Participants can be executed only in serial. Parallel execution is not supported. The case takes approximately two minutes to finish.


## Post-processing

The VTU files from both solvers could be rendered and inspected with ParaView.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The VTU files from both solvers could be rendered and inspected with ParaView.
Both participants create export VTU files, which can be viewed using ParaView.

Comment on lines +64 to +66
## Further information

The simulation is stationary and the results of the pressure and the velocity fields are as follows:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Further information
The simulation is stationary and the results of the pressure and the velocity fields are as follows:
The results of the pressure and the velocity fields are as follows:

Comment on lines +1 to +3
add_executable(porous_media_dumux main.cc)
target_compile_definitions(porous_media_dumux PUBLIC "ENABLEMONOLITHIC=0")
target_link_libraries(porous_media_dumux PRIVATE dumux-precice)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
add_executable(porous_media_dumux main.cc)
target_compile_definitions(porous_media_dumux PUBLIC "ENABLEMONOLITHIC=0")
target_link_libraries(porous_media_dumux PRIVATE dumux-precice)
add_executable(free_flow_dumux main.cc)
target_compile_definitions(free_flow_dumux PUBLIC "ENABLEMONOLITHIC=0")
target_link_libraries(free_flow_dumux PRIVATE dumux-precice)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants