Revert #634 and update reference results #640
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If we touch this, I would suggest to directly switch to the default everywhere, e.g. <acceleration:IQN-ILS>
<data name="Displacement" mesh="Solid-Mesh" />
<data name="Force" mesh="Solid-Mesh" />
</acceleration:IQN-ILS> |
73 tasks
|
Since we have now released v3.2.0, we can merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After releasing preCICE v3.2.0, we should update the reference results for the system tests and revert the changes introduced by #634. Besides the performance improvements we are missing, the configuration parameter
<preconditioner update-on-threshold="<bool>" />is not available pre-v3.2.0.Checklist:
changelog-entries/<PRnumber>.md. -> Removed the one from Enforce recomputation of preconditioner to avoid regression #634.