Skip to content

Adgrid Bid Adapter : use common code #13123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 22, 2025
Merged

Adgrid Bid Adapter : use common code #13123

merged 6 commits into from
May 22, 2025

Conversation

soman
Copy link
Contributor

@soman soman commented May 21, 2025 •
edited
Loading

#13121

This PR contains common code, so after this PR is merged, my PR needs to be merged.

Type of change

  • Bugfix

  • Feature

  • New bidder adapter

  • Updated bidder adapter

  • Code style update (formatting, local variables)

  • Refactoring (no functional changes, no api changes)

  • Build related changes

  • CI related changes

  • Does this change affect user-facing APIs or examples documented on http://prebid.org?

  • Other

Description of change

Other information

soman added 2 commits May 21, 2025 20:27
@soman
Used common code
7c66666 
This PR contains common code, so after this PR is merged, my PR needs to be merged.
@soman
Merge branch 'master' into adgrid-new-version
5ae23a4
@github-actions GitHub Actions
Copy link

Tread carefully! This PR adds 1 linter error (possibly disabled through directives):

  • modules/adgridBidAdapter.js (+1 error)

@github-actions GitHub Actions
Copy link

Tread carefully! This PR adds 1 linter error (possibly disabled through directives):

  • modules/adgridBidAdapter.js (+1 error)

@github-actions GitHub Actions
Copy link

Tread carefully! This PR adds 1 linter error (possibly disabled through directives):

  • modules/adgridBidAdapter.js (+1 error)

@ChrisHuie ChrisHuie self-requested a review May 21, 2025 16:17
@ChrisHuie ChrisHuie self-assigned this May 21, 2025
@soman
Copy link
Contributor Author

soman commented May 22, 2025

@ChrisHuie Could you please merge this branch now that the common code is available?

@ChrisHuie ChrisHuie changed the title Used common code Adgrid Bid Adapter : use common code May 22, 2025
@patmmccann
Copy link
Collaborator

you havr tthis linting error
/home/circleci/Prebid.js/modules/adgridBidAdapter.js
6:1 error import "../libraries/nexx360Utils/index.js" cannot be resolved prebid/validate-imports

@github-actions GitHub Actions
Copy link

Tread carefully! This PR adds 1 linter error (possibly disabled through directives):

  • modules/adgridBidAdapter.js (+1 error)

@soman
Copy link
Contributor Author

soman commented May 22, 2025

you havr tthis linting error /home/circleci/Prebid.js/modules/adgridBidAdapter.js 6:1 error import "../libraries/nexx360Utils/index.js" cannot be resolved prebid/validate-imports

This is the file, so why did the error occur?

https://github.com/prebid/Prebid.js/blob/master/libraries/nexx360Utils/index.js

@ChrisHuie ChrisHuie merged commit 91def29 into prebid:master May 22, 2025
5 of 6 checks passed
pm-komal-kumari pushed a commit to pm-komal-kumari/Prebid.js that referenced this pull request May 28, 2025
@soman
Adgrid Bid Adapter : use common code (prebid#13123)
a70c8eb 
* Used common code

This PR contains common code, so after this PR is merged, my PR needs to be merged.

* Removed extra line

* Removed whitespace

* Added a comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisHuie ChrisHuie ChrisHuie approved these changes

Assignees

@ChrisHuie ChrisHuie

Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@soman @patmmccann @ChrisHuie